[ros] apply suggestions from 21417#21426
Merged
yosifkit merged 1 commit intoMay 11, 2026
Merged
Conversation
fail early on deb download use binary format for sha check Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
changed the title
Diff for 5e7ed22:diff --git a/_bashbrew-cat b/_bashbrew-cat
index 458fd2e..ae47729 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -13,7 +13,7 @@ Directory: ros/humble/ubuntu/jammy/ros-base
Tags: humble-ros-core, humble-ros-core-jammy
Architectures: amd64, arm64v8
-GitCommit: eb5634cf92ba079897e44fb7541d3b78aa6cf717
+GitCommit: 58af41813ba67f611943c35c551387d652fcdbde
Directory: ros/humble/ubuntu/jammy/ros-core
Tags: jazzy-perception, jazzy-perception-noble
@@ -28,7 +28,7 @@ Directory: ros/jazzy/ubuntu/noble/ros-base
Tags: jazzy-ros-core, jazzy-ros-core-noble
Architectures: amd64, arm64v8
-GitCommit: eb5634cf92ba079897e44fb7541d3b78aa6cf717
+GitCommit: 58af41813ba67f611943c35c551387d652fcdbde
Directory: ros/jazzy/ubuntu/noble/ros-core
Tags: kilted-perception, kilted-perception-noble
@@ -43,7 +43,7 @@ Directory: ros/kilted/ubuntu/noble/ros-base
Tags: kilted-ros-core, kilted-ros-core-noble
Architectures: amd64, arm64v8
-GitCommit: eb5634cf92ba079897e44fb7541d3b78aa6cf717
+GitCommit: 58af41813ba67f611943c35c551387d652fcdbde
Directory: ros/kilted/ubuntu/noble/ros-core
Tags: lyrical-perception, lyrical-perception-resolute
diff --git a/ros_humble-ros-core-jammy/Dockerfile b/ros_humble-ros-core-jammy/Dockerfile
index c0e6b9c..6b51315 100644
--- a/ros_humble-ros-core-jammy/Dockerfile
+++ b/ros_humble-ros-core-jammy/Dockerfile
@@ -19,8 +19,8 @@ RUN apt-get update && apt-get install -q -y --no-install-recommends \
# Setup ROS Apt sources
-RUN curl -L -s -o /tmp/ros2-apt-source.deb https://github.com/ros-infrastructure/ros-apt-source/releases/download/1.1.0/ros2-apt-source_1.1.0.jammy_all.deb \
- && echo "1600cb8cc28258a39bffc1736a75bcbf52d1f2db371a4d020c1b187d2a5a083b /tmp/ros2-apt-source.deb" | sha256sum --strict --check \
+RUN curl -L -s -f -o /tmp/ros2-apt-source.deb https://github.com/ros-infrastructure/ros-apt-source/releases/download/1.2.0/ros2-apt-source_1.2.0.jammy_all.deb \
+ && echo "767884cf4ed03116b9d64438930a832ed854147ae435279a7924dfdf60f94433 */tmp/ros2-apt-source.deb" | sha256sum --strict --check \
&& apt-get update \
&& apt-get install /tmp/ros2-apt-source.deb \
&& rm -f /tmp/ros2-apt-source.deb \
diff --git a/ros_jazzy-ros-core-noble/Dockerfile b/ros_jazzy-ros-core-noble/Dockerfile
index 5e28f03..2614680 100644
--- a/ros_jazzy-ros-core-noble/Dockerfile
+++ b/ros_jazzy-ros-core-noble/Dockerfile
@@ -19,8 +19,8 @@ RUN apt-get update && apt-get install -q -y --no-install-recommends \
# Setup ROS Apt sources
-RUN curl -L -s -o /tmp/ros2-apt-source.deb https://github.com/ros-infrastructure/ros-apt-source/releases/download/1.1.0/ros2-apt-source_1.1.0.noble_all.deb \
- && echo "35441f3092fd05773a3c397fab38661bec466584c7a1f1c05366579997cb5fe7 /tmp/ros2-apt-source.deb" | sha256sum --strict --check \
+RUN curl -L -s -f -o /tmp/ros2-apt-source.deb https://github.com/ros-infrastructure/ros-apt-source/releases/download/1.2.0/ros2-apt-source_1.2.0.noble_all.deb \
+ && echo "0804d9b13db770eb87019be414cd78378835228ad5fa801fc88758596dd8f7e5 */tmp/ros2-apt-source.deb" | sha256sum --strict --check \
&& apt-get update \
&& apt-get install /tmp/ros2-apt-source.deb \
&& rm -f /tmp/ros2-apt-source.deb \
diff --git a/ros_kilted-ros-core-noble/Dockerfile b/ros_kilted-ros-core-noble/Dockerfile
index b78ebd3..0126a8f 100644
--- a/ros_kilted-ros-core-noble/Dockerfile
+++ b/ros_kilted-ros-core-noble/Dockerfile
@@ -19,8 +19,8 @@ RUN apt-get update && apt-get install -q -y --no-install-recommends \
# Setup ROS Apt sources
-RUN curl -L -s -o /tmp/ros2-apt-source.deb https://github.com/ros-infrastructure/ros-apt-source/releases/download/1.1.0/ros2-apt-source_1.1.0.noble_all.deb \
- && echo "35441f3092fd05773a3c397fab38661bec466584c7a1f1c05366579997cb5fe7 /tmp/ros2-apt-source.deb" | sha256sum --strict --check \
+RUN curl -L -s -f -o /tmp/ros2-apt-source.deb https://github.com/ros-infrastructure/ros-apt-source/releases/download/1.2.0/ros2-apt-source_1.2.0.noble_all.deb \
+ && echo "0804d9b13db770eb87019be414cd78378835228ad5fa801fc88758596dd8f7e5 */tmp/ros2-apt-source.deb" | sha256sum --strict --check \
&& apt-get update \
&& apt-get install /tmp/ros2-apt-source.deb \
&& rm -f /tmp/ros2-apt-source.deb \Relevant Maintainers:
|
yosifkit
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fail early on deb download
use binary format for sha check
Based on: #21417 (review)
Cross-referencing: osrf/docker_images#880